성공적인코드리뷰 문화 사내 발표

  • Published on
    20-Aug-2015

  • View
    256

  • Download
    2

Embed Size (px)

Transcript

  1. 1. Tips for a successful code review
  2. 2. Introduction to the Personal Software Process PSPby Watts S. Humphrey.
  3. 3. how can they achieve a level of code quality thatcauses pride among the professionals involved?The answer: CODE REVIEW.
  4. 4. There are three types of code reviews:pair programming,formal code review,lightweight code review.
  5. 5. benefit of code review
  6. 6. good idea; bad execution
  7. 7. Worst code Review
  8. 8. intellectually vain can make code reviews a nightmare of shouting and hurt feelings. But despite all that they are very useful.
  9. 9. Learn to enjoy the code reviews.
  10. 10. how do we make code reviews useful?
  11. 11. Code reviews SHOULDT be performed to find errors in the code.Code reviews SHOULDT be performed to enforce coding standards.
  12. 12. Keep a positive attitude. remember: you are not the code!
  13. 13. Time, Your coworkers are waiting for you.
  14. 14. Code writer (before code review)1. Document2. At least 2 days before3. Code revision number JIRA open
  15. 15. Code writer (ing) .
  16. 16. ReviewerAsk questions rather than make statements.
  17. 17. ReviewerAvoid the "Why" questions.
  18. 18. ReviewerMake sure the discussion stays focused on the code and not the coder.
  19. 19. Standard / Checklist
  20. 20. Moderator
  21. 21. Beware the "Big Brother" effect.