Contributor Day - WordCamp Lublin 2017 - przegląd motywów

  • Published on
    21-Jan-2018

  • View
    2.150

  • Download
    1

Embed Size (px)

Transcript

  • Contributor DayPrzegld motyww

  • Co jest wymagane by sprawdza motywy?

    Konto na wordpress.org

    Moliwo testowania motyww (posiadanie lokalnego rodowiska do testw)

    Wiedza o strukturze motyww w WordPressie

    Podstawowa wiedza o HTML, CSS, JavaScript i PHP

    http://wordpress.org

  • Przyda si te Slack

    Konto na chat.wordpress.org

    Pomoc w zakresie przegldu motyww mona uzyska na kanale #themereview

    Opis jak zaoy konto: https://make.wordpress.org/chat/ Uwaga! Logowanie odbywa si poprzez mail postaci nazwa_uzytkownika_na_wordpress_org@chat.wordpress.org

    http://chat.wordpress.orghttps://make.wordpress.org/chat/mailto:nazwa_uzytkownika_na_wordpress_org@chat.wordpress.org

  • Trac

    https://themes.trac.wordpress.org/

    Dostp do wtkw uzyskuje si przez konto WordPress.org - dlatego naley je zaoy przed rozpoczciem prac przy przegldaniu motyww.

    https://themes.trac.wordpress.org/

  • Warto ledzi

    https://make.wordpress.org/themes/

    Na tym blogu pojawiaj si informacje o zmianach wymaga, procedur oraz raporty ze

    spotka zespou ds. przegldu motyww.

    https://make.wordpress.org/themes/

  • Jak otrzyma motyw do przegldu?

    https://make.wordpress.org/themes/handbook/review/

    https://make.wordpress.org/themes/handbook/review/

  • Od tego momentu mamy 48 godzin na odezwanie si w przypisanym wtku

    The team voted to automatically remove a reviewer if they have not added a comment in the ticket for 2 days after being assigned as the reviewer on a ticket. The ticket would then go back to the top of the queue so that another reviewer could pick it up

    rdo: https://make.wordpress.org/themes/2017/01/17/january-17-2017-meeting-notes/

    https://make.wordpress.org/themes/2017/01/17/january-17-2017-meeting-notes/

  • Struktura recenzji

    Kwestie wymagajce naprawy (Required)

    Kwestie warte poprawienia (Recommended)

    Kwestie dodatkowe (Notes)

  • W przegldzie motywu nie chodzi tylko o przejcie procedury przegldu przez motyw ale te o dzielenie si wiedz

  • Przegld odbywa si w formie konwersacji pomidzy recenzentem a autorem motywu, ktra odbywa si w wtku.

    W wypadku znalezienia problemw z motywem, autor ma 7 dni na odpowied, w przeciwnym wypadku wtek zostanie zamknity z powodu braku aktywnoci. Tak samo recenzent ma 7 dni na odpowied odnonie poprawek - w wypadku gdy brakuje nam na to czasu, warto podtrzyma konwersacj aby wtek nie zosta zamknity lub nam zabrany.

  • Zaczynamy przegld

  • rodowisko testowe Instalujemy MAMP, LAMP, XAMP, WAMP (zalenie od systemu

    operacyjnego): https://make.wordpress.org/core/handbook/tutorials/installing-a-local-server/

    Instalujemy WordPressa

    Instalujemy wtyczki Theme Check, Monster Widget, Log Deprecated Notices, Query Monitor, Regenerate Thumbnails

    Ustawiamy zmienn WP_DEBUG na TRUE w wp-config.php

    Instalujemy dane testowe: https://codex.wordpress.org/Theme_Unit_Test

    W tym miejscu warto zrobi backup WordPressa :)

    Instalujemy motyw, ktry bdziemy recenzowa

    https://make.wordpress.org/core/handbook/tutorials/installing-a-local-server/https://make.wordpress.org/core/handbook/tutorials/installing-a-local-server/https://codex.wordpress.org/Theme_Unit_Test

  • Weryfikujemy czy autor nie narusza licencji GPL

    Czy nie sprzedaje na swojej stronie lub Theme Forest motyww niezgodnie z licencj GPL (gwnie limit stron na ktrych mona uywa motywu dyskwalifikuje)

    Sprawdzamy czy motyw uywa zdj, grafik, fontw, bibliotek zgodnych z licencj GPL

    Upewniamy si, e miniaturka motywu uywa (o ile w ogle uywa) wycznie zdj na licencji zgodnej z GPL

  • Licencje zgodne z GPL

    https://make.wordpress.org/themes/handbook/review/resources/#gpl-compatible-image%c2%a0licenses

    https://www.gnu.org/licenses/license-list.pl.html

    https://make.wordpress.org/themes/handbook/review/resources/#gpl-compatible-image%c2%a0licenseshttps://make.wordpress.org/themes/handbook/review/resources/#gpl-compatible-image%c2%a0licenseshttps://make.wordpress.org/themes/handbook/review/resources/#gpl-compatible-image%c2%a0licenseshttps://www.gnu.org/licenses/license-list.pl.html

  • Sprawdzamy niezbdne wymagania (Required)

    Testujemy motyw wtyczk Theme Check

    Testujemy wedug listy na: https://make.wordpress.org/themes/handbook/review/required/

    https://make.wordpress.org/themes/handbook/review/required/https://make.wordpress.org/themes/handbook/review/required/https://make.wordpress.org/themes/handbook/review/required/

  • Sprawdzamy wymagania dodatkowe (Recommended)

    Wedug listy: https://make.wordpress.org/themes/handbook/review/recommended/

    https://make.wordpress.org/themes/handbook/review/recommended/https://make.wordpress.org/themes/handbook/review/recommended/https://make.wordpress.org/themes/handbook/review/recommended/

  • Weryfikujemy niuanse (Notes) ;-)

    Wedug listy: https://make.wordpress.org/themes/handbook/review/recommended/#design

    oraz wasnych upodoba i wiedzy

    https://make.wordpress.org/themes/handbook/review/recommended/#designhttps://make.wordpress.org/themes/handbook/review/recommended/#designhttps://make.wordpress.org/themes/handbook/review/recommended/#design

  • Warto pamita zanim zaczniesz przegld motywu

  • Zamykanie przegldu ze wzgldu na bdy bezpieczestwa i prefiksowaniardo: https://make.wordpress.org/themes/2016/07/12/meeting-notes-for-2016-july-12/ Themes that do not fullfill the review baseline will be closed. The

    ticket will be closed if the theme has more then 3 prefixing or security issues. This also applies to the admin review queue.

    It is not the end when a ticket is closed. The discussion can still continue and an update can always be updated.

    https://make.wordpress.org/themes/2016/07/12/meeting-notes-for-2016-july-12/https://make.wordpress.org/themes/2016/07/12/meeting-notes-for-2016-july-12/https://make.wordpress.org/themes/2016/07/12/meeting-notes-for-2016-july-12/

  • Przykadowa odpowied w takiej sytuacji:Reviewers are now allowed to close the ticket if 3 or more security or prefixing issues are found.

    This theme is being closed because the following security/prefixing issues have been found :

    Please do not get discouraged by the ticket being closed. If you have questions you can ask them here or in the #themereview channel on Slack. Fix these issues and ensure you have checked your theme for additional security or prefixing problems.

    You can read up more on security and prefixing on our resources page: https://make.wordpress.org/themes/handbook/review/resources/

    Also take this opportunity to carefully review your theme against theme requirements listed in the reference below.

    ref: https://make.wordpress.org/themes/handbook/review/required/

    Once the issues are fixed upload the new version and we will review it again.https://wordpress.org/themes/getting-started/

    https://make.wordpress.org/themes/handbook/review/resources/https://make.wordpress.org/themes/handbook/review/resources/https://make.wordpress.org/themes/handbook/review/required/https://wordpress.org/themes/getting-started/

  • Zamykanie przegldu ze wzgldu na liczne bdyrdo: https://make.wordpress.org/themes/2016/08/23/meeting-summary-2016-23-08/W wypadku gdy motyw posiada 5 powanych bdw, mona odgrnie zakoczy przegld - warto przy tym skorzysta z poniszego szablonu odpowiedzi. Przy czym bdy grupujemy wedug rodzaju:Closing tickets should be done for 5 or more distinct issues. Examples: Theme has multiple places where text strings are not translatable group these into 1

    distinct issue

    Using custom functions instead of core functions such as the_posts_pagination, the_archive_title, the_excerpt group into 1 issue

    https://make.wordpress.org/themes/2016/08/23/meeting-summary-2016-23-08/

  • Szablon odpowiedzi:I am sorry but because the following five errors are present I am closing this ticket.

    #issue1

    #issue2

    #issue3

    #issue4

    #issue5

    Do not get discouraged. A closed ticket is not the end. We want you to resubmit your theme. We do ask that you spend a bit more time making sure that your theme meets all [https://make.wordpress.org/themes/handbook/review/required/ the requirements] before we make it live.

    If you need help with anything or want me to explain further, dont hesitate to post here in this ticket. Im happy to answer any questions you have. Or, feel free to post over on our [https://make.wordpress.org/chat/ Slack] [https://wordpress.slack.com/messages/themereview channel].

  • Ograniczenie liczby tagw tematycznych do 3rdo: https://make.wordpress.org/themes/2016/09/06/meeting-summary-2016-09-06/Motyw moe uywa do 3 tagw dotyczcych jego tematyki (blog, education itp.), pozostae tagi nie maj limitu.Because were seeing more and more themes adding upwards of all 9 subject tags, we decided on a limit of 3 subject tags per theme. This goes into effect immediately.

    https://make.wordpress.org/themes/2016/09/06/meeting-summary-2016-09-06/https://make.wordpress.org/themes/2016/09/06/meeting-summary-2016-09-06/https://make.wordpress.org/themes/2016/09/06/meeting-summary-2016-09-06/

  • There have been a few questions about integrating social media elements in a theme.

    As theme features:

    Social media links with icons settings areallowed. Social media buttons to share posts isplugin territory. Social media like and follow buttons areplugin territory.

    In the customizer with the theme authors links.

    Social media links with icons settings areallowed. Social media like and follow buttons isnot allowed.

    https://make.wordpress.org/themes/2017/01/29/agenda-for-2017-january-31/

    Social media w motywach

    https://make.wordpress.org/themes/2017/01/29/agenda-for-2017-january-31/

  • Wtyczka czy motyw?

    https://make.wordpress.org/themes/handbook/review/required/#core-functionality-and-features

    themes wont be allowed to add a Custom CSS box to their themes falls under core functionality first requirement

    https://make.wordpress.org/themes/handbook/review/required/#core-functionality-and-featureshttps://make.wordpress.org/themes/handbook/review/required/#core-functionality-and-features

  • Up selling

    Autorzy powinni uywa ekranu personalizacji motywu do up sellingu

    Zakazany jest agresywny up selling

  • Typowe bdy cz. 1

    https://make.wordpress.org/themes/2017/03/25/review-statistics

    Funkcje, ktre autorzy motyww implementowali sami zamiast uy API WordPressa:

    Logo Custom CSS Custom excerpt Custom pagination

    https://make.wordpress.org/themes/2017/03/25/review-statistics

  • Typowe bdy cz. 2

    https://make.wordpress.org/themes/2017/03/25/review-statistics

    Missing escaping or using the wrong functions Text that is not translation ready Missing prefix Missing license or copyright information for included assets Unused code or files PHP notices, errors or warnings Missing sanitization, or using the wrong functions Options in the customizer that are not working Scripts or styles are not enqueued Style tags does not correspond with theme functionality, or are

    deprecated

    https://make.wordpress.org/themes/2017/03/25/review-statistics

  • Popularne pliki CSS/JS nie powinny by prefiksowane

    https://github.com/grappler/wp-standard-handles/

    https://github.com/grappler/wp-standard-handles/

  • Przydatne zasoby

  • Struktura plikw motywu

    https://wphierarchy.com/

    https://wphierarchy.com/

  • Troch o prefiksach

    http://themereview.co/prefix-all-the-things/

    http://themereview.co/prefix-all-the-things/

  • Troch o typowych bdach

    https://make.wordpress.org/themes/2016/04/16/most-common-admin-review-issues/

    https://make.wordpress.org/themes/2016/04/16/most-common-admin-review-issues/

  • Tagi motyww

    https://make.wordpress.org/themes/handbook/review/required/theme-tags/

    https://make.wordpress.org/themes/handbook/review/required/theme-tags/